Thanks for the feedback.
The change you suggested for the duplicate comment() line issue worked well. I didn't realise you could split a function over several lines like you did.
And the hook_subroutine() function is exactly what I needed. I re-read the instructions on your github page and now have a better understanding of how that function works. As you indicated, I think I should be using stringhi_hook, as the printing code is checking for end of message with a BMI (ie high bit set) instruction - although, in practice, both stringhi and stringhiz will probably work.
Since you didn't make any comment on my repeated use of the following, I'm guessing means that I've done that correctly. I did wonder if there was a more efficient way of doing it:
I'll fix the file name case mismatch as well.
The change you suggested for the duplicate comment() line issue worked well. I didn't realise you could split a function over several lines like you did.
And the hook_subroutine() function is exactly what I needed. I re-read the instructions on your github page and now have a better understanding of how that function works. As you indicated, I think I should be using stringhi_hook, as the printing code is checking for end of message with a BMI (ie high bit set) instruction - although, in practice, both stringhi and stringhiz will probably work.
Since you didn't make any comment on my repeated use of the following, I'm guessing means that I've done that correctly. I did wonder if there was a more efficient way of doing it:
Code:
label(addr,"label")expr(addr1, make_lo("label"))expr(addr1+2, make_hi("label"))Statistics: Posted by KenLowe — Sun Apr 21, 2024 12:00 am